fix(SXMC-198): Fix goflow compiler error #44
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
SXMC-198
A go upgrade from 1.17 -> 1.19 introduced a bug fix in go 1.18 which raises an error if any variables are declared but unused. The upgrade itself failed to compile on the CI due to an old variable that was declared but not used, but was merged anyway.
As a result, the pipeline on the PR to change code ownership of the repo failed. We need to unblock this pipeline in order to complete the code ownership transfer before the end of the transition period.
Solution
Taking other graphs as an example, I used the
PrinterCtx
node to use the declared variable and generated the graph.Caveats/Notes
gotestsum
, a command I found in the go ci workflow.io/ioutil
which was caught by the linter.gofumpt -w
to format certain files that were caught by the linter.panic: load embedded ruleguard rules: rules/rules.go:13: can't load fmt
which @alk-jtessier solved by upgrading the linter.Prime: @alk-jtessier
cc: @alkemics/sxm-core